Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve some screenshot Coordinates Mode issues #1695

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

eglitise
Copy link
Collaborator

This PR fixes some issues when using the screenshot Coordinates Mode:

  • If the user taps or swipes on the screenshot, then, while the action is being executed, moves a mouse to another location and attempts a tap or swipe again, the new mouse position was not updated
  • If the user clicks and holds to start a swipe action, then moves the mouse outside the screenshot bounds, the swipe action was not canceled
  • If the user moves the mouse outside the screenshot bounds, the coordinates overlay values were not cleared

A side-effect of these changes is that the circle/line drawn over the screenshot as part of the tap/swipe action is now dismissed as soon as the screenshot loading overlay appears, instead of after the action finishes. This does not affect MJPEG mode since the loading overlay is not shown there.

Resolves #1682.

@github-actions github-actions bot added the fix This resolves a user-facing problem label Sep 17, 2024
@eglitise eglitise merged commit 048731f into appium:main Sep 17, 2024
6 checks passed
@eglitise eglitise deleted the mouse-after-screenshot-click branch September 17, 2024 09:39
laib3 pushed a commit to laib3/appium-inspector that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix This resolves a user-facing problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Mouse movements not captured during screenshot refresh in Coordinates Mode
2 participants