feat: get usbmuxd socket address from USBMUXD_SOCKET_ADDRESS environment #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…socket path Signed-off-by: Muvaffak Onus <[email protected]>
|
@muvaf I don't see any changes since the last commit. Have you pushed your fixes? |
|
@mykola-mokhnach I was waiting on your take for this question, just pushed the change after testing. |
mykola-mokhnach
approved these changes
Dec 23, 2024
muvaf
changed the title
…var is given Signed-off-by: Muvaffak Onus <[email protected]>
|
@mykola-mokhnach I think you need to manually approve the workflows. |
mykola-mokhnach
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Dec 23, 2024
## [2.8.0](v2.7.27...v2.8.0) (2024-12-23) ### Features * get usbmuxd socket address from USBMUXD_SOCKET_ADDRESS environment ([#190](#190)) ([9a5be45](9a5be45))
|
🎉 This PR is included in version 2.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi @muvaf, congrats: the Appium project wants to compensate you for this contribution! Please reply to this comment mentioning @jlipps and @KazuCocoa and sharing your OpenCollective account name, so that we can initiate payment! Or let us know if you decline to receive compensation via OpenCollective. Thank you! |
|
@jlipps @KazuCocoa Thanks, my account handle is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
usbmuxdis run without root user, it listens on a different path.usbmuxditself uses this env var if it's given.Tested manually with a real iPhone.