Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use new selenium atoms from remote debugger #1884

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Conversation

jlipps
Copy link
Member

@jlipps jlipps commented Aug 15, 2023

this is technically a breaking change since we're removing a deprecated method (moveTo). not sure how much we care.

fixes appium/appium#17013
fixes appium/appium#18951

@jlipps
Copy link
Member Author

jlipps commented Aug 15, 2023

let's see what CI does. if it passes then we can merge and release appium/appium-remote-debugger#268 as non-beta.

all the web e2e tests passed for me locally with this change.

@jlipps jlipps changed the title chore: use new selenium atoms from remote debugger feat: use new selenium atoms from remote debugger Aug 16, 2023
@jlipps jlipps merged commit 2707c01 into master Aug 16, 2023
@jlipps jlipps deleted the jlipps/new-atoms branch August 16, 2023 17:49
@github-actions
Copy link
Contributor

🎉 This PR is included in version 4.34.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need to update remote debugger selenium atoms to latest Safari atoms that trigger alerts never get resolved
3 participants