Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Selenium version to 4.7.0 #1811

Merged
merged 2 commits into from
Dec 2, 2022

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

Related to SeleniumHQ/selenium#11347

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@nirtal85
Copy link

nirtal85 commented Dec 2, 2022

Hi team, could you please merge this ASAP? we can't use Appium anymore - we must use the latest selenium because we do web-mobile combined tests that use CDP.

@valfirst
Copy link
Collaborator

valfirst commented Dec 2, 2022

It seems more changes are needed, the tests are failed:

        Caused by:
        org.openqa.selenium.WebDriverException: java.lang.NoSuchMethodException: org.openqa.selenium.remote.ProtocolHandshake.createSession(org.openqa.selenium.remote.http.HttpHandler, java.io.InputStream, long)
        Build info: version: '4.7.0', revision: '0a5b49d16f'
        System info: os.name: 'Mac OS X', os.arch: 'x86_64', os.version: '10.16', java.version: '1.8.0_352'
        Driver info: driver.version: AndroidDriver
            at io.appium.java_client.remote.AppiumProtocolHandshake.createSession(AppiumProtocolHandshake.java:130)
            at io.appium.java_client.remote.AppiumProtocolHandshake.createSession(AppiumProtocolHandshake.java:102)
            at io.appium.java_client.remote.AppiumCommandExecutor.createSession(AppiumCommandExecutor.java:194)
            at io.appium.java_client.remote.AppiumCommandExecutor.execute(AppiumCommandExecutor.java:262)
            at org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:541)
            ... 7 more

            Caused by:
            java.lang.NoSuchMethodException: org.openqa.selenium.remote.ProtocolHandshake.createSession(org.openqa.selenium.remote.http.HttpHandler, java.io.InputStream, long)
                at java.lang.Class.getDeclaredMethod(Class.java:2130)
                at io.appium.java_client.remote.AppiumProtocolHandshake.createSession(AppiumProtocolHandshake.java:122)
                ... 11 more

The root cause is this change: SeleniumHQ/selenium@558e0a0.

@valfirst valfirst self-requested a review December 2, 2022 08:10
@mykola-mokhnach
Copy link
Contributor Author

Updated session creation

@mykola-mokhnach mykola-mokhnach merged commit 843941a into appium:master Dec 2, 2022
@mykola-mokhnach mykola-mokhnach deleted the rotatable branch December 2, 2022 09:28
@mykola-mokhnach
Copy link
Contributor Author

@SrinivasanTarget Could you please release this changes in 8.3.0?

@SrinivasanTarget
Copy link
Member

@SrinivasanTarget Could you please release this changes in 8.3.0?

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants