Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use Java 9+ APIs instead of outdated/3rd-party APIs #2048

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

valfirst
Copy link
Collaborator

Change list

  • Use Java 9 convenience factory methods for collections instead of Guava Collections
  • Use Map.entry(..) instead of new AbstractMap.SimpleEntry<>(..)
  • Use java.util.Objects.requireNonNull(..) (actually available since Java 7) instead of Guava Preconditions.checkNotNull(..)
  • Deprecate MobileCommand.prepareArguments(..) in favour of Map.of(..)
  • Use java.util.function.Function instead of AppiumFunction
  • Replace !Optional.isPresent() with Optional.isEmpty()

Types of changes

What types of changes are you proposing/introducing to Java client?

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@valfirst valfirst merged commit a9240e3 into appium:master Oct 18, 2023
@valfirst valfirst deleted the use-java-9+-apis branch October 18, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants