Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly unwrap driver instance if the ContextAware object is deeply nested #2052

Merged
merged 5 commits into from
Oct 22, 2023

Conversation

mykola-mokhnach
Copy link
Contributor

Change list

Related to #2051

Types of changes

  • No changes in production code.
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@mykola-mokhnach mykola-mokhnach changed the title fix: Properly unwrap driver instance if the ContextAware object is deeply nested WIP: fix: Properly unwrap driver instance if the ContextAware object is deeply nested Oct 20, 2023
@mykola-mokhnach mykola-mokhnach changed the title WIP: fix: Properly unwrap driver instance if the ContextAware object is deeply nested fix: Properly unwrap driver instance if the ContextAware object is deeply nested Oct 20, 2023
@mykola-mokhnach
Copy link
Contributor Author

Failed android tests are expected because the CI fails to start emulator. The fix itself works properly though

@mykola-mokhnach mykola-mokhnach merged commit fac489f into appium:master Oct 22, 2023
@mykola-mokhnach mykola-mokhnach deleted the wraps_check branch October 22, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants