refactor: Deprecate custom functional interfaces #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested review from
mykola-mokhnach,
SrinivasanTarget and
saikrishna321
as code owners
| @@ -27,16 +27,13 @@ | |||
|
|
|||
| public class AndroidFunctionTest extends BaseAndroidTest { | |||
There was a problem hiding this comment.
this test does not make sense if it uses standard functions. It must be removed together with the deprecated stuff
valfirst
force-pushed
the
deprecate-custom-functional-interfaces
branch
from
d83e403 to
8a14133
Compare
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| public class AndroidAbilityToUseSupplierTest extends BaseAndroidTest { | |||
|
|
|||
| private final ActionSupplier<AndroidTouchAction> horizontalSwipe = () -> { | |||
There was a problem hiding this comment.
Please revert changes to tests. We will remove it as soon as deprecated interfaces are removed
valfirst
force-pushed
the
deprecate-custom-functional-interfaces
branch
from
8a14133 to
dba99a8
Compare
mykola-mokhnach
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Custom functional interfaces are not needed anymore: Selenium closed all gaps in functional Java support.
Types of changes
What types of changes are you proposing/introducing to Java client?