Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add activities unittest #310

Merged
merged 5 commits into from
Jan 7, 2019
Merged

Add activities unittest #310

merged 5 commits into from
Jan 7, 2019

Conversation

tadashi0713
Copy link
Contributor

tadashi0713
tadashi0713 commented Jan 6, 2019
View reviewed changes
appium/webdriver/extensions/activities.py
@@ -67,7 +67,7 @@ def wait_activity(self, activity, timeout, interval=1):

This is an Android-only method.

:Agrs:
:Args:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo

@tadashi0713 tadashi0713 closed this Jan 6, 2019
@tadashi0713 tadashi0713 reopened this Jan 6, 2019
tadashi0713
tadashi0713 commented Jan 6, 2019
View reviewed changes
ci-requirements.txt
@@ -4,6 +4,7 @@ isort==4.3.4
pylint==1.9.3
autopep8==1.4.3
httpretty==0.9.6
pytest==4.0.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed pytest version because from 4.1.0 release this issue happens and test fails
pytest-dev/pytest-cov#252
pytest-dev/pytest#4564

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. thanks

KazuCocoa
KazuCocoa reviewed Jan 7, 2019
View reviewed changes
test/unit/webdriver/device/activities_test.py
)
driver.start_activity('com.example.myapp', '.ExampleActivity')

d = json.loads(httpretty.last_request().body.decode('utf-8'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update into 2 cases, minimal and maximum arguments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added, thanks

@KazuCocoa KazuCocoa merged commit 4874112 into appium:master Jan 7, 2019
@KazuCocoa
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KazuCocoa KazuCocoa KazuCocoa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tadashi0713 @KazuCocoa