Fix computing string length with indirect symbols from symbols files. #2
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indirect symbols are copied twice to the 'p' variable, this is the second time:
cctools/misc/strip.c
Lines 4217 to 4228 in cbe977a
This means we need to add the size of the indirect symbol to the size of the 'p' memory contents twice.
This seems to already be happening here:
cctools/misc/strip.c
Lines 3820 to 3823 in cbe977a
and:
cctools/misc/strip.c
Lines 3845 to 3848 in cbe977a
but one scenario (symbols files) was missing.
Ref: FB13327641 (contains test case).
Ref: dotnet/macios#19157