gitignore: add cmake build artifacts

[thoughtpolice]

No description provided.

[alexmiller-apple]

Can I suggest just using a build directory that's outside of the source directory? The existing build/ directory is meant as scripts and tooling to do the building, not as the intended build output directory.

[thoughtpolice]

Well, "in nixos", the build system sort of automatically invokes cmake for me during the configure stage and automatically moves to the build directory, and build is generally the "normal" place people run cmake builds. I can change that but -- is there any directory already covered by gitignore, then? It's tedious to see it clutter up git status output.

[mpilman]

I tend to agree with @thoughtpolice in a way that I think it is very ugly that we have a build directory in the first place. IMHO we should move these things somewhere else (build-scripts?). build is kind of the default for cmake (as in: people and tools use it as default - cmake doesn't care).

But this will probably need changes in the CI. @AlvinMooreSr do you have any thoughts on this?

[AlvinMooreSr]

I am not against accepting a PR against the release-6.1 branch which changes our build directory to build-tools.

[alexmiller-apple]

Okay, then let me go create a set of PRs to copy build/ to build-tools/, so that we can adjust the CI without a window of failures.

[mpilman]

This is not the correct fix. I created an issue to track this and we should fix this before 7.0