Skip to content

Commit

Permalink
Build improvements from Gradle Enterprise testing (#1853)
Browse files Browse the repository at this point in the history
Motivation:

Gradle Enterprise build evaluation found a few improvements that could be made.

Modifications:
* Enable local build caching.  Doesn't do much for CI builds unless you set up a remote build cache, but will make repeated local builds significantly faster.
* Enable configure-on-demand.  This means gradle will only configure the projects participating in the build, rather than all of them.  With the amount of projects you have, this is a noticeable speedup, especially for short, single project tasks.
* Update the specified junit platform version to 1.8.0.  This is what was being used anyways, due to transitive dependencies, but having the specified version be lower caused extraneous dependency resolve requests, adding 1-3s to just about every task (including IntelliJ sync).
* Set the CI environment variable on one of the CI workflows that was missing it, but that's just bookkeeping, I don't expect it to affect anything.

Result:

Faster local builds and in case a remote cache is used.
  • Loading branch information
rnett authored and idelpivnitskiy committed Sep 29, 2021
1 parent c15d825 commit 0b4043c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ jobs:
with:
languages: ${{ matrix.language }}
- name: Execute gradle build
with:
CI: true
run: ./gradlew --parallel clean assemble
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
4 changes: 3 additions & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
#

org.gradle.parallel=true
org.gradle.caching=true
org.gradle.configureondemand=true
org.gradle.jvmargs=-Xms2g -Xmx4g -dsa -da -ea:io.servicetalk... -XX:+HeapDumpOnOutOfMemoryError

group=io.servicetalk
Expand Down Expand Up @@ -55,7 +57,7 @@ jmhCoreVersion=1.33
jmhPluginVersion=0.6.6

junitVersion=4.13.2
junitPlatformVersion=1.7.2
junitPlatformVersion=1.8.0
junit5Version=5.8.0
testngVersion=7.4.0
hamcrestVersion=2.2
Expand Down

0 comments on commit 0b4043c

Please sign in to comment.