JDK19 builds for PRB (#2433)

.github/workflows/ci-prb-reports.yml

@@ -10,7 +10,7 @@ jobs:
     strategy:
       # Matrix should be coordinated with ci-prb.yml.
       matrix:
-        java: [ 8, 11.0.16+8, 17 ]
+        java: [ 8, 11.0.16+8, 17, 19 ]
         os: [ ubuntu-latest ]
     steps:
       - name: Download Artifacts

.github/workflows/ci-prb.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        java: [ 8, 11.0.16+8, 17 ]
+        java: [ 8, 11.0.16+8, 17, 19 ]
         os: [ ubuntu-latest ]
     steps:
       - name: Checkout Code

.github/workflows/ci-prq-reports.yml

@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        java: [ 8, 11.0.16+8, 17 ]
+        java: [ 8, 11.0.16+8, 17, 19 ]
     steps:
       - name: Download Artifacts
         uses: dawidd6/action-download-artifact@e6e25ac3a2b93187502a8be1ef9e9603afc34925

.github/workflows/ci-prq.yml

@@ -8,7 +8,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        java: [ 8, 11.0.16+8, 17 ]
+        java: [ 8, 11.0.16+8, 17, 19 ]
     steps:
       - name: Checkout Code
         uses: actions/checkout@v3

servicetalk-http-api/src/main/java/io/servicetalk/http/api/MultiAddressHttpClientBuilder.java

@@ -70,18 +70,18 @@ default SingleAddressInitializer<U, R> append(SingleAddressInitializer<U, R> toA
     MultiAddressHttpClientBuilder<U, R> executor(Executor executor);
 
     /**
-     * {@inheritDoc}
-     *
-     * <p>Provides the base execution strategy for all clients created from this builder and the default strategy for
+     * Sets the {@link HttpExecutionStrategy} to be used for client callbacks when executing client requests for all
+     * clients created from this builder.
+     * <p>
+     * Provides the base execution strategy for all clients created from this builder and the default strategy for
      * the {@link SingleAddressHttpClientBuilder} used to construct client instances. The
      * {@link #initializer(SingleAddressInitializer)} may be used for some customization of the execution strategy for a
      * specific single address client instance, but may not reduce the offloading to be performed. Specifically, the
      * initializer may introduce additional offloading via
      * {@link SingleAddressHttpClientBuilder#executionStrategy(HttpExecutionStrategy)} and may add filters which
      * influence the computed execution strategy.
-     *
-     * <p>Specifying an execution strategy will affect the offloading used during the execution of client requests:
-     *
+     * <p>
+     * Specifying an execution strategy will affect the offloading used during the execution of client requests:
      * <dl>
      *     <dt>Unspecified or {@link HttpExecutionStrategies#defaultStrategy()}
      *     <dd>The resulting client instances will use the default safe strategy for each API variant and
@@ -101,9 +101,10 @@ default SingleAddressInitializer<U, R> append(SingleAddressInitializer<U, R> toA
      *     <dd>{@link SingleAddressHttpClientBuilder} instances created by the client will start with the provided
      *     strategy and may add additional offloading as required by added filters.
      * </dl>
-     *
-     * @param strategy {@inheritDoc}
-     * @return {@inheritDoc}
+     * @param strategy {@link HttpExecutionStrategy} to use. If callbacks to the application code may block then those
+     * callbacks must request to be offloaded.
+     * @return {@code this}.
+     * @see HttpExecutionStrategies
      */
     @Override
     MultiAddressHttpClientBuilder<U, R> executionStrategy(HttpExecutionStrategy strategy);

servicetalk-http-api/src/main/java/io/servicetalk/http/api/SingleAddressHttpClientBuilder.java

@@ -173,10 +173,10 @@ SingleAddressHttpClientBuilder<U, R> appendConnectionFilter(
     SingleAddressHttpClientBuilder<U, R> executor(Executor executor);
 
     /**
-     * {@inheritDoc}
-     *
-     * <p>Specifying an execution strategy affects the offloading used during execution of client requests:
-     *
+     * Sets the {@link HttpExecutionStrategy} to be used for client callbacks when executing client requests for all
+     * clients created from this builder.
+     * <p>
+     * Specifying an execution strategy affects the offloading used during execution of client requests:
      * <dl>
      *     <dt>Unspecified or {@link HttpExecutionStrategies#defaultStrategy()}
      *     <dd>Execution of client requests will use a safe (non-blocking) execution strategy appropriate for the
@@ -204,9 +204,10 @@ SingleAddressHttpClientBuilder<U, R> appendConnectionFilter(
      *     callbacks <strong style="text-transform: uppercase;">MAY</strong> only block during the offloaded portions of
      *     the client request execution.
      * </dl>
-     *
-     * @param strategy {@inheritDoc}
-     * @return {@inheritDoc}
+     * @param strategy {@link HttpExecutionStrategy} to use. If callbacks to the application code may block then those
+     * callbacks must request to be offloaded.
+     * @return {@code this}.
+     * @see HttpExecutionStrategies
      */
     @Override
     SingleAddressHttpClientBuilder<U, R> executionStrategy(HttpExecutionStrategy strategy);