Skip to content

Commit

Permalink
Deprecating HttpServerBuilder protected methods (#1830)
Browse files Browse the repository at this point in the history
Motivation:

Upcoming refactoring of `HttpServerBuilder` to become an interface will
remove some methods from public API. Therefore, those methods should be
deprecated.

Modifications:

- Deprecated `HttpServerBuilder#doListen` - both variants,
- Deprecated `HttpServerBuilder#buildExecutionContext`.

Result:

Preparing potential users to the removal of these methods in upcoming
release.
  • Loading branch information
Dariusz Jedrzejczyk committed Sep 15, 2021
1 parent 274f0d6 commit f3261db
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,11 @@ public final Single<ServerContext> listenBlockingStreaming(final BlockingStreami
* ignore the {@link StreamingHttpRequest#payloadBody() payload body} of incoming requests.
* @return A {@link Single} that completes when the server is successfully started or terminates with an error if
* the server could not be started.
* @deprecated This method will be removed. If you depend upon it consider copying the implementation from
* {@code DefaultHttpServerBuilder#doListen(ConnectionAcceptor, StreamingHttpService, HttpExecutionStrategy,
* boolean)}
*/
@Deprecated
protected abstract Single<ServerContext> doListen(@Nullable ConnectionAcceptor connectionAcceptor,
StreamingHttpService service,
HttpExecutionStrategy strategy,
Expand Down

0 comments on commit f3261db

Please sign in to comment.