Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky Test: DefaultHttpExecutionStrategyTest #1716

Closed
Scottmitch opened this issue Aug 4, 2021 · 18 comments
Closed

Flaky Test: DefaultHttpExecutionStrategyTest #1716

Scottmitch opened this issue Aug 4, 2021 · 18 comments
Labels
flaky tests Unit tests are flaky

Comments

@Scottmitch
Copy link
Member

Scottmitch commented Aug 4, 2021 •
edited
Loading

./gradlew clean, ./gradlew build
macOS 11.5, JDK 16.0.2+7
local development of #1673 based upon 9ac4f98 ... will rebase and re-evaluate.

[12] NO_EXEC_OFFLOAD_SEND

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:424)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:408)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:233)

...

Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[Test worker,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:428)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:402)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:320)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:61)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:53)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:231)
		... 144 more
@Scottmitch Scottmitch added the flaky tests Unit tests are flaky label Aug 4, 2021
@Scottmitch
Copy link
Member Author 

[6] EXEC_OFFLOAD_SEND

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:424)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:408)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:233)

...

Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-19,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:428)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:402)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:320)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:61)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:53)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:231)
		... 115 more

@Scottmitch
Copy link
Member Author 

[8] NO_EXEC_OFFLOAD_ALL

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:424)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:408)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:233)

...

Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-19,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:428)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:402)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:320)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:61)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:53)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:231)
		... 115 more

@Scottmitch
Copy link
Member Author

Scottmitch commented Aug 24, 2021 •
edited
Loading 

[8] NO_EXEC_OFFLOAD_ALL

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:406)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:390)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:215)

...

	Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-19,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:410)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:384)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:302)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:61)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:53)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:213)
		... 115 more

@tkountis
Copy link
Contributor

tkountis commented Aug 26, 2021 •
edited
Loading

https://github.com/apple/servicetalk/runs/3433340045

DefaultHttpExecutionStrategyTest.[6] EXEC_OFFLOAD_SEND
java.lang.AssertionError: Async errors occurred. See suppressed!

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:420)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:404)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:229)
	
...

	Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-3,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:424)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:398)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:316)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:61)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:53)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:227)

@tkountis tkountis mentioned this issue Aug 26, 2021
Merged
@Scottmitch
Copy link
Member Author

local macOS build

[8] NO_EXEC_OFFLOAD_ALL

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:420)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:404)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:229)

...

	Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-19,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:424)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:398)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:316)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:61)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:53)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:227)
		... 115 more

@Scottmitch
Copy link
Member Author

local macOS build

[2] EXEC_OFFLOAD_ALL

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:379)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:363)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:186)

...

	Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-19,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:383)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:357)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:275)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:61)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:53)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:184)
		... 115 more

@Scottmitch
Copy link
Member Author

local macOS build

[6] EXEC_OFFLOAD_SEND

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:379)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:363)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:186)
	
...

	Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-19,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:383)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:357)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:275)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:61)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:53)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:184)
		... 115 more

@Scottmitch
Copy link
Member Author

local macOS build, JDK-17.0.1

[6] EXEC_OFFLOAD_SEND

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:374)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:358)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:181)

...

	Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-1,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:378)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:352)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:270)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:61)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:53)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:179)
		... 114 more

@Scottmitch
Copy link
Member Author

local macOS build, JDK-17.0.1

[6] EXEC_OFFLOAD_SEND

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:374)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:358)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:181)

...

Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-1,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:378)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:352)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:270)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:63)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:55)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:179)
		... 114 more

@Scottmitch
Copy link
Member Author

local macOS build, JDK-17.0.1

[2] EXEC_OFFLOAD_ALL

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:374)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:358)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:181)

...

Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-1,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:378)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:352)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:270)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:63)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:55)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:179)

@idelpivnitskiy
Copy link
Member

https://github.com/apple/servicetalk/pull/2031/checks?check_run_id=4588887927

DefaultHttpExecutionStrategyTest.[6] EXEC_OFFLOAD_SEND
java.lang.AssertionError: Async errors occurred. See suppressed!

Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-1,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:378)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:352)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:270)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:63)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:55)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:179)
		... 113 more

@Scottmitch
Copy link
Member Author

local macOS build, JDK-17.0.1

[6] EXEC_OFFLOAD_SEND

at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:374)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:358)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:181)
	
...

Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-1,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:378)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:352)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:270)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:63)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:55)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:179)

@idelpivnitskiy
Copy link
Member

https://github.com/apple/servicetalk/pull/2149/checks?check_run_id=5577340701

DefaultHttpExecutionStrategyTest.[2] EXEC_OFFLOAD_ALL

java.lang.AssertionError: Async errors occurred. See suppressed!
...
Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-3,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:371)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:345)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:263)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:63)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:55)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:172)
		... 114 more

@bondolo
Copy link
Contributor

bondolo commented Mar 17, 2022 •
edited
Loading

https://github.com/apple/servicetalk/runs/5579447103

(apologies for the console paste)

DefaultHttpExecutionStrategyTest > offloadSendSingle(Params) > io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(Params)[2] FAILED
[723](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:723)
    java.lang.AssertionError: Async errors occurred. See suppressed!
[724](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:724)
        at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
[725](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:725)
        at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
[726](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:726)
        at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:367)
[727](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:727)
        at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:351)
[728](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:728)
        at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:174)
[729](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:729)

[730](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:730)
DefaultHttpExecutionStrategyTest > offloadSendSingle(Params) > io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(Params)[6] FAILED
[731](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:731)
    java.lang.AssertionError: Async errors occurred. See suppressed!
[732](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:732)
        at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
[733](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:733)
        at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
[734](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:734)
        at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:367)
[735](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:735)
        at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:351)
[736](https://github.com/apple/servicetalk/runs/5579447103?check_suite_focus=true#step:7:736)
        at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:174)

@Scottmitch
Copy link
Member Author

https://github.com/apple/servicetalk/pull/2151/checks?check_run_id=5588128755

DefaultHttpExecutionStrategyTest.[2] EXEC_OFFLOAD_ALL

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:367)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:351)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:174)

	Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-3,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:371)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:345)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:263)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:63)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:55)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:172)
		..

DefaultHttpExecutionStrategyTest.[6] EXEC_OFFLOAD_SEND

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:367)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:351)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:174)


	Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-3,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:371)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:345)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:263)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:63)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:55)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:172)
		... 114 more

@Scottmitch Scottmitch mentioned this issue Mar 17, 2022
Merged
@Scottmitch
Copy link
Member Author

https://github.com/apple/servicetalk/runs/5593059206

DefaultHttpExecutionStrategyTest.[2] EXEC_OFFLOAD_ALL

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:367)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:351)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:174)

	Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-3,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:371)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:345)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:263)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:63)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:55)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:172)
		... 114 more

DefaultHttpExecutionStrategyTest.[6] EXEC_OFFLOAD_SEND

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:367)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:351)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:174)
	

	Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-3,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:371)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:345)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:263)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:63)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:55)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:172)
		... 114 more

@Scottmitch
Copy link
Member Author

Scottmitch commented Mar 17, 2022 •
edited
Loading

https://github.com/apple/servicetalk/runs/5593149557

DefaultHttpExecutionStrategyTest.[2] EXEC_OFFLOAD_ALL

java.lang.AssertionError: Async errors occurred. See suppressed!
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:57)
	at io.servicetalk.test.resources.TestUtils.assertNoAsyncErrors(TestUtils.java:42)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyNoErrors(DefaultHttpExecutionStrategyTest.java:367)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifySend(DefaultHttpExecutionStrategyTest.java:351)
	at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:174)
	
	Suppressed: java.lang.AssertionError: Unexpected thread requested from cancel. Thread: Thread[ForkJoinPool-1-worker-1,5,main]
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.addError(DefaultHttpExecutionStrategyTest.java:371)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.verifyThread(DefaultHttpExecutionStrategyTest.java:345)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest$ThreadAnalyzer.lambda$instrumentSend$11(DefaultHttpExecutionStrategyTest.java:263)
		at io.servicetalk.concurrent.api.ComposedCancellable.cancel(ComposedCancellable.java:33)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.slowPath(ContextPreservingCancellable.java:63)
		at io.servicetalk.concurrent.api.ContextPreservingCancellable.cancel(ContextPreservingCancellable.java:55)
		at io.servicetalk.concurrent.internal.SequentialCancellable.cancel(SequentialCancellable.java:69)
		at io.servicetalk.http.api.DefaultHttpExecutionStrategyTest.offloadSendSingle(DefaultHttpExecutionStrategyTest.java:172)

@bondolo bondolo removed their assignment Mar 3, 2023
@idelpivnitskiy
Copy link
Member

This was not flaky for more than a year. Reopen if it happens again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky tests Unit tests are flaky
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bondolo @tkountis @idelpivnitskiy @Scottmitch