Add Publisher.flatMapConcatSingle #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scottmitch
force-pushed
the
pub_flat_map_concat_single
branch
from
6ca8867 to
c38b6c4
Compare
|
build failure attributed to #1716 |
Scottmitch
commented
Mar 18, 2022
| static <T, R> Publisher<R> flatMapConcatSingle(final Publisher<T> publisher, | ||
| final Function<? super T, ? extends Single<? extends R>> mapper) { | ||
| return defer(() -> { | ||
| final Queue<Item<R>> results = newUnboundedSpscQueue(4); |
There was a problem hiding this comment.
note there is a queue here, and in flatMapMergeSingle. we can optimize and combine in the future with a native operator implementation but for now reusing flatMapMergeSingle is good enough to get started and keeps complexity down.
Motivation: Publisher.flatMapConcatSingle provides similar semantics to Publisher.flatMapMergeSingle except the results are returned in the same order as the original Publisher.
Scottmitch
force-pushed
the
pub_flat_map_concat_single
branch
from
c38b6c4 to
897b45f
Compare
bondolo
reviewed
Mar 21, 2022
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Outdated
Show resolved
Hide resolved
...-concurrent-api/src/main/java/io/servicetalk/concurrent/api/PublisherFlatMapConcatUtils.java
Outdated
Show resolved
Hide resolved
...-concurrent-api/src/main/java/io/servicetalk/concurrent/api/PublisherFlatMapConcatUtils.java
Outdated
Show resolved
Hide resolved
...lk-concurrent-internal/src/main/java/io/servicetalk/concurrent/internal/ConcurrentUtils.java
Outdated
Show resolved
Hide resolved
bondolo
added
enhancement
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/Publisher.java
Show resolved
Hide resolved
...urrent-api/src/test/java/io/servicetalk/concurrent/api/PublisherFlatMapConcatSingleTest.java
Outdated
Show resolved
Hide resolved
...urrent-api/src/test/java/io/servicetalk/concurrent/api/PublisherFlatMapConcatSingleTest.java
Outdated
Show resolved
Hide resolved
...lk-concurrent-internal/src/main/java/io/servicetalk/concurrent/internal/ConcurrentUtils.java
Outdated
Show resolved
Hide resolved
...urrent-api/src/test/java/io/servicetalk/concurrent/api/PublisherFlatMapConcatSingleTest.java
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Publisher.flatMapConcatSingle provides similar semantics to
Publisher.flatMapMergeSingle except the results are returned
in the same order as the original Publisher.