Support controlling peerHost and SNI hostname inference for GRPC clients #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: This change follows from [a change to HTTP client builders](apple#1561) and exposes the same capabilities to GRPC client builders. Modifications: - `SingleAddressGrpcClientBuilder` has new methods: `inferPeerHost`, `inferPeerPort`, and `inferSniHostname` which allow configuring the behaviour of the TLS handshake and inference of the corresponding configurations. Result: Users are able to disable peerHost and peerPort inference and can now use an empty peerHost when they so desire. The SNI hostname inference from the provided address can also be disabled in cases when the address used for connection should not be passed in the SNI extension.
Scottmitch
approved these changes
Jul 19, 2021
idelpivnitskiy
approved these changes
Jul 20, 2021
chemicL
pushed a commit
that referenced
this pull request
Jul 21, 2021
…nts (#1678) Motivation: This change follows from [a change to HTTP client builders](#1561) and exposes the same capabilities to GRPC client builders. Modifications: - `SingleAddressGrpcClientBuilder` has new methods: `inferPeerHost`, `inferPeerPort`, and `inferSniHostname` which allow configuring the behaviour of the TLS handshake and inference of the corresponding configurations. Result: Users are able to disable peerHost and peerPort inference and can now use an empty peerHost when they so desire. The SNI hostname inference from the provided address can also be disabled in cases when the address used for connection should not be passed in the SNI extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This change follows from a change to HTTP client builders
and exposes the same capabilities to GRPC client builders.
Modifications:
SingleAddressGrpcClientBuilderhas new methods:inferPeerHost,inferPeerPort, andinferSniHostnamewhich allow configuring thebehaviour of the TLS handshake and inference of the corresponding
configurations.
Result:
Users are able to disable peerHost and peerPort inference and can now
use an empty peerHost when they so desire. The SNI hostname inference
from the provided address can also be disabled in cases when the
address used for connection should not be passed in the SNI extension.