MultiAddressHttpClientBuilder deprecation and de-deprecation refactoring
#1722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The MultiAddressHttpClientBuilder deprecated methods which should stay and allow configuring the `ExecutionContext` (`ioExecutor, `executionStrategy`, `bufferAllocator`). Furthermore, methods influencing the client filters have not been deprecated, but should, as the `SingleAddressInitializer` allows configuring the filters in a satisfactory fashion. Modifications: - List the changes - Removed `@Deprecated` annotation from `ioExecutor`, `executionStrategy`, and `bufferAllocator` methods, - Deprecated `MultiAddressHttpClientFilterFactory`, - Deprecated `appendClientFilter` methods accepting `MultiAddressHttpClientFilterFactory`. Result: The current API reflects the future direction for `MultiAddressHttpClientBuilder` and how it should be used.
Scottmitch
approved these changes
Aug 7, 2021
tkountis
approved these changes
Aug 9, 2021
chemicL
commented
Aug 9, 2021
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Following @Scottmitch comment from #1721 (comment) I also added deprecation for this method. Please re-review @tkountis @Scottmitch.
|
lgtm |
Scottmitch
approved these changes
Aug 10, 2021
chemicL
pushed a commit
that referenced
this pull request
Aug 11, 2021
…oring (#1722) MultiAddressHttpClientBuilder deprecation and de-deprecation refactoring Motivation: The `MultiAddressHttpClientBuilder` deprecated methods which should stay and allow configuring the `ExecutionContext` (`ioExecutor, `executionStrategy`, `bufferAllocator`). Furthermore, methods influencing the client filters have not been deprecated, but should, as the `SingleAddressInitializer` allows configuring the filters in a satisfactory fashion. Modifications: - Removed `@Deprecated` annotation from `ioExecutor`, `executionStrategy`, and `bufferAllocator` methods, - Deprecated `MultiAddressHttpClientFilterFactory`, - Deprecated `appendClientFilter` methods accepting `MultiAddressHttpClientFilterFactory`, - Deprecated `StreamingHttpClientFilterFactory#asMultiAddressClientFilter`. Result: The current API reflects the future direction for `MultiAddressHttpClientBuilder` and how it should be used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The
MultiAddressHttpClientBuilderdeprecated methods which should stayand allow configuring the
ExecutionContext(ioExecutor,executionStrategy,bufferAllocator). Furthermore, methodsinfluencing the client filters have not been deprecated, but should, as
the
SingleAddressInitializerallows configuring the filters in asatisfactory fashion.
This PR is a prequel to #1721 which introduces an intended cleanup of the
MultiAddressHttpClientBuilderAPI.Modifications:
@Deprecatedannotation fromioExecutor,executionStrategy,and
bufferAllocatormethods,MultiAddressHttpClientFilterFactory,appendClientFiltermethods acceptingMultiAddressHttpClientFilterFactory,StreamingHttpClientFilterFactory#asMultiAddressClientFilter.Result:
The current API reflects the future direction for
MultiAddressHttpClientBuilderand how it should be used.