Improve split cookie crumbs test in H2ToStH1UtilsTest
#1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We used `ConstantHashCharSequence` to make sure that two headers fall into the same bucket in internal `HttpHeaders` data structure. However, the `hashCode()` is taken only if `CharSequence` implements `AsciiBuffer` or `AsciiString`. Otherwise, a static utility is used to compute case-insensitive `hashCode`. As the result, `ConstantHashCharSequence` does not provide what we expected. Modifications: - Remove `ConstantHashCharSequence` and use `caseInsensitiveHashCode` / `hashCodeAscii` utilities to make sure that two header names result in the same bucket based on their `hashCode` value and `ARRAY_SIZE_HINT` Result: Test verifies the behavior it was created for.
bondolo
reviewed
Aug 24, 2021
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/H2ToStH1UtilsTest.java
Show resolved
Hide resolved
servicetalk-http-netty/src/test/java/io/servicetalk/http/netty/H2ToStH1UtilsTest.java
Show resolved
Hide resolved
bondolo
approved these changes
Aug 26, 2021
idelpivnitskiy
added a commit
that referenced
this pull request
Sep 24, 2021
Motivation: We used `ConstantHashCharSequence` to make sure that two headers fall into the same bucket in internal `HttpHeaders` data structure. However, the `hashCode()` is taken only if `CharSequence` implements `AsciiBuffer` or `AsciiString`. Otherwise, a static utility is used to compute case-insensitive `hashCode`. As the result, `ConstantHashCharSequence` does not provide what we expected. Modifications: - Remove `ConstantHashCharSequence` and use `caseInsensitiveHashCode` / `hashCodeAscii` utilities to make sure that two header names result in the same bucket based on their `hashCode` value and `ARRAY_SIZE_HINT` Result: Test verifies the behavior it was created for.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We used
ConstantHashCharSequenceto make sure that two headers fallinto the same bucket in internal
HttpHeadersdata structure. However,the
hashCode()is taken only ifCharSequenceimplementsAsciiBufferorAsciiString. Otherwise, a static utility is usedto compute case-insensitive
hashCode. As the result,ConstantHashCharSequencedoes not provide what we expected.Modifications:
ConstantHashCharSequenceand usecaseInsensitiveHashCode/hashCodeAsciiutilities to make sure that two header names resultin the same bucket based on their
hashCodevalue andARRAY_SIZE_HINTResult:
Test verifies the behavior it was created for.
This test was introduced in #1425.