Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecutionStrategy simplification deprecations #1781

Merged
merged 7 commits into from
Sep 2, 2021

Conversation

bondolo
Copy link
Contributor

@bondolo bondolo commented Sep 2, 2021

Motivation:
removed methods should be deprecated before they are removed.
Modifications:
Marks methods to be removed in #1695 as deprecated and, where possible,
suggests alternatives.
Result:
Warnings for future method removals are provided.

Motivation:
removed methods should be deprecated before they are removed.
Modifications:
Marks methods to be removed in apple#1695 as deprecated and, where possible,
suggests alternatives.
Result:
Warnings for future method removals are provided.
@bondolo bondolo added the API PR with API changes (New or Deprecated) label Sep 2, 2021
@bondolo bondolo self-assigned this Sep 2, 2021
@bondolo
Copy link
Contributor Author

bondolo commented Sep 2, 2021

This change will need to be integrated before #1695 and will be back ported to 0.41 branch.

…bstract builders so that subclasses don't fail.
Copy link
Member

@idelpivnitskiy idelpivnitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bondolo bondolo merged commit 950e021 into apple:main Sep 2, 2021
bondolo added a commit to bondolo/servicetalk that referenced this pull request Sep 3, 2021
Motivation:
removed methods should be deprecated before they are removed.
Modifications:
Marks methods to be removed in apple#1695 as deprecated and, where possible,
provides and suggests alternatives.
Result:
Warnings for future method removals are provided.
bondolo added a commit that referenced this pull request Sep 3, 2021
Motivation:
removed methods should be deprecated before they are removed.
Modifications:
Marks methods to be removed in #1695 as deprecated and, where possible,
provides and suggests alternatives.
Result:
Warnings for future method removals are provided.
@bondolo
Copy link
Contributor Author

bondolo commented Sep 3, 2021

0.41 (9a605c2)

@bondolo bondolo deleted the deprecate-grpc-defaultStrategy branch September 3, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API PR with API changes (New or Deprecated)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants