Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend japicmp.sh to compare versus local build #1810

Merged
merged 4 commits into from
Sep 9, 2021

Conversation

bondolo
Copy link
Contributor

@bondolo bondolo commented Sep 7, 2021

Motivation:
It is useful to be able to compare the Java API compatibility of a
local build against a prior release.
Modifications:
Extend japicmp.sh to provide capability to compare an old version
of ServiceTalk against a local build.
Result:
Additional API compatibility comparison capability.

Motivation:
It is useful to be able to compare the Java API compatibility of a
local build against a prior release.
Modifications:
Extend `japicmp.sh` to provide capability to compare an old version
of ServiceTalk against a local build.
Result:
Additional API compatibility comparison capability.
@bondolo bondolo added the enhancement New feature or request label Sep 7, 2021
@bondolo bondolo self-assigned this Sep 7, 2021
@bondolo
Copy link
Contributor Author

bondolo commented Sep 7, 2021

Most of the rest of the changes are due either to shellcheck or shfmt.

scripts/japicmp.sh Outdated Show resolved Hide resolved
@bondolo bondolo requested a review from chemicL September 8, 2021 15:24
scripts/japicmp.sh Outdated Show resolved Hide resolved
Copy link
Member

@idelpivnitskiy idelpivnitskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, thank you! 🎖️

@bondolo bondolo merged commit 202dd46 into apple:main Sep 9, 2021
idelpivnitskiy pushed a commit that referenced this pull request Sep 24, 2021
Motivation:
It is useful to be able to compare the Java API compatibility of a
local build against a prior release.
Modifications:
Extend `japicmp.sh` to provide capability to compare an old version
of ServiceTalk against a local build.
Result:
Additional API compatibility comparison capability.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants