Fix race condition in SpliceFlatStreamToMetaSingle #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: SpliceFlatStreamToMetaSingle has a race condition which may result in concurrency invocation of a Subscriber which is prohibited by the Reactive Streams specification [1]. [1] https://github.com/reactive-streams/reactive-streams-jvm/blob/v1.0.3/README.md#1.3 Modifications: - Use a DelayedSubscription so onSubscribe is invoked before the Subscriber reference is made visible to other threads which may invoke terminal methods on the Subscriber. Result: SpliceFlatStreamToMetaSingle is more compliant with RS spec and provides more predictable behavior.
Scottmitch
added a commit
that referenced
this pull request
Sep 29, 2021
Motivation: SpliceFlatStreamToMetaSingle has a race condition which may result in concurrency invocation of a Subscriber which is prohibited by the Reactive Streams specification [1]. [1] https://github.com/reactive-streams/reactive-streams-jvm/blob/v1.0.3/README.md#1.3 Modifications: - Use a DelayedSubscription so onSubscribe is invoked before the Subscriber reference is made visible to other threads which may invoke terminal methods on the Subscriber. Result: SpliceFlatStreamToMetaSingle is more compliant with RS spec and provides more predictable behavior.
|
0.41 (66eb875) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
SpliceFlatStreamToMetaSingle has a race condition which may result in
concurrency invocation of a Subscriber which is prohibited by the
Reactive Streams specification [1].
[1] https://github.com/reactive-streams/reactive-streams-jvm/blob/v1.0.3/README.md#1.3
Modifications:
Subscriber reference is made visible to other threads which may
invoke terminal methods on the Subscriber.
Result:
SpliceFlatStreamToMetaSingle is more compliant with RS spec and provides
more predictable behavior.