Remove enforcedPlatform from test fixtures #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In apple#1827 `enforcedPlatform` was used for importing several BOM files related to tests. For the modules which publish artifacts to be used by other modules the use of `enforcedPlatform` is incorrect and Maven Java publish tasks fail. Modifications: All `testFixtures` imports of BOM files use `platform` rather than `enforcedPlatform`. For dependencies for test execution `enforcedPlatform` is still appropriate and continues to be used. Result: Maven publish tasks succeed.
Scottmitch
approved these changes
Oct 11, 2021
idelpivnitskiy
approved these changes
Oct 11, 2021
|
Tested using |
|
Test failure due to #1579 |
bondolo
added a commit
that referenced
this pull request
Oct 13, 2021
Motivation: In #1827 `enforcedPlatform` was used for importing several BOM files related to tests. For the modules which publish artifacts to be used by other modules the use of `enforcedPlatform` is incorrect and Maven Java publish tasks fail. Modifications: All `testFixtures` imports of BOM files use `platform` rather than `enforcedPlatform`. For dependencies for test execution `enforcedPlatform` is still appropriate and continues to be used. Result: Maven publish tasks succeed.
|
0.41 - ebf2d8d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In #1827
enforcedPlatformwas used for importing several BOM filesrelated to tests. For the modules which publish artifacts to be used by
other modules the use of
enforcedPlatformis incorrect and MavenJava publish tasks fail.
Modifications:
All
testFixturesimports of BOM files useplatformrather thanenforcedPlatform. For dependencies for test executionenforcedPlatformis still appropriate and continues to be used.Result:
Maven publish tasks succeed.