gRPC catch-all filters should implement HttpExecutionStrategyInfluencer #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: gRPC client and server unconditionally adds a "catch-all" filter, which does not implement `HttpExecutionStrategyInfluencer`, leading to unexpected offloading for users when they use aggregated and blocking api. Modifications: - Implement `HttpExecutionStrategyInfluencer` for both: `CatchAllHttpServiceFilter` and `CatchAllHttpClientFilter`; Result: No unexpected offloading when gRPC users use aggregated or blocking API.
Scottmitch
approved these changes
Oct 12, 2021
idelpivnitskiy
added a commit
that referenced
this pull request
Oct 13, 2021
…er (#1884) Motivation: gRPC client and server unconditionally adds a "catch-all" filter, which does not implement `HttpExecutionStrategyInfluencer`, leading to unexpected offloading for users when they use aggregated and blocking api. Modifications: - Implement `HttpExecutionStrategyInfluencer` for both: `CatchAllHttpServiceFilter` and `CatchAllHttpClientFilter`; Result: No unexpected offloading when gRPC users use aggregated or blocking API.
idelpivnitskiy
added a commit
that referenced
this pull request
Oct 13, 2021
Motivation: #1884 used `appendNonOffloadingServiceFilter` that is available only in the main branch. Modifications: - Replace `appendNonOffloadingServiceFilter` with `appendServiceFilter`; Result: No compile issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
gRPC client and server unconditionally adds a "catch-all" filter, which
does not implement
HttpExecutionStrategyInfluencer, leading tounexpected offloading for users when they use aggregated and blocking
api.
Modifications:
HttpExecutionStrategyInfluencerfor both:CatchAllHttpServiceFilterandCatchAllHttpClientFilter;Result:
No unexpected offloading when gRPC users use aggregated or blocking API.