Deprecate gRPC service filters #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: gRPC service filters are not as flexible as HTTP service filters. Their reuse is limited due to the strict typing with gRPC definitions. HTTP filters are the best choice most of the time. If required users can embed their custom logic in the actual service implementation where the decoded protos can be accessed. Modifications: - Deprecated `GrpcServiceFilterFactory`, - Deprecated `GrpcServiceFactory#appendServiceFilter` and `GrpcServiceFactory#appendServiceFilterFactory` methods, - `Generator` adds deprecations to corresponding generated classes/interfaces and methods. - Added deprecation warning in the project documentation. Result: Service filters have been deprecated and are prepared for removal in a future release.
idelpivnitskiy
approved these changes
Oct 14, 2021
chemicL
pushed a commit
to chemicL/servicetalk
that referenced
this pull request
Oct 18, 2021
Motivation: gRPC service filters are not as flexible as HTTP service filters. Their reuse is limited due to the strict typing with gRPC definitions. HTTP filters are the best choice most of the time. If required users can embed their custom logic in the actual service implementation where the decoded protos can be accessed. Modifications: - Deprecated `GrpcServiceFilterFactory`, - Deprecated `GrpcServiceFactory#appendServiceFilter` and `GrpcServiceFactory#appendServiceFilterFactory` methods, - `Generator` adds deprecations to corresponding generated classes/interfaces and methods. - Added deprecation warning in the project documentation. Result: Service filters have been deprecated and are prepared for removal in a future release.
|
0.41: 4083567 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
gRPC service filters are not as flexible as HTTP service filters. Their
reuse is limited due to the strict typing with gRPC definitions. HTTP
filters are the best choice most of the time. If required users can
embed their custom logic in the actual service implementation where the
decoded protos can be accessed.
Modifications:
GrpcServiceFilterFactory,GrpcServiceFactory#appendServiceFilterandGrpcServiceFactory#appendServiceFilterFactorymethods,Generatoradds deprecations to corresponding generatedclasses/interfaces and methods.
Result:
Service filters have been deprecated and are prepared for removal in a
future release.