Fix build caching for protoc plugin #1895
Conversation
This ensures that the test proto files will be regenerated if the plugin sources change.
|
Looking through the rest of the codebase, there are multiple places where this occurs (wherever your protoc plugin is used, essentially). I don't know if they all have as severe an effect as this one, but they should all be fixed eventually. I wasn't planning on including it in this PR but I can if it's a big deal. |
|
Thank you @rnett for spending the time on it. I verified that indeed the fix works for the tests in the |
Motivation: Recent introduction of Gradle caching mechanism caused the `Generator` class modifications to have no effect if the gRPC proto compiler plugin was already in the local cache. The build stages did not communicate properly that the prerequisites to generate proto classes have been changed and require assembling. Modifications: - Include protoc plugin as task input manually. This ensures that the test proto files will be regenerated if the plugin sources change, - Use classpath normalization for protoc plugin jar file. Result: Tests in `servicetalk-grpc-protoc` module use the modified `Generator` class to generate classes.
Fixes the issue brought up in #1853 (comment).
It does this by manually adding the plugin jar as a task input to the protoc tasks, ensuring that if the plugin sources (and thus jar) change the task will have a new cache key.