HttpLoadBalancerFactory should override newLoadBalancer with 3 args
#1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: apple#1831 added a new `LoadBalancerFactory#newLoadBalancer(String, Publisher, ConnectionFactory)` overload, but didn't override it in `HttpLoadBalancerFactory`. Modifications: - Add `HttpLoadBalancerFactory.newLoadBalancer(...)` overload with 3 arguments; Result: `HttpLoadBalancerFactory` follows `LoadBalancerFactory` contract with http-specific types.
chemicL
suggested changes
Nov 8, 2021
servicetalk-http-api/src/main/java/io/servicetalk/http/api/HttpLoadBalancerFactory.java
Show resolved
Hide resolved
chemicL
approved these changes
Nov 15, 2021
idelpivnitskiy
added a commit
that referenced
this pull request
Nov 15, 2021
…gs (#1935) Motivation: #1831 added a new `LoadBalancerFactory#newLoadBalancer(String, Publisher, ConnectionFactory)` overload, but didn't override it in `HttpLoadBalancerFactory`. Modifications: - Add `HttpLoadBalancerFactory.newLoadBalancer(...)` overload with 3 arguments; Result: `HttpLoadBalancerFactory` follows `LoadBalancerFactory` contract with http-specific types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#1831 added a new
LoadBalancerFactory#newLoadBalancer(String, Publisher, ConnectionFactory)overload, but didn't override it in
HttpLoadBalancerFactory.Modifications:
HttpLoadBalancerFactory.newLoadBalancer(...)overload with 3arguments;
Result:
HttpLoadBalancerFactoryfollowsLoadBalancerFactorycontract withhttp-specific types.