SingleThreadedScheduler should fallback execution upon offloading failure
#1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailure Motivation: When the `Executor` provided by the user fails to accept the task executed by the `SingleThreadedScheduler`, the exception is ignored and the scheduler is no longer usable. The exceptions from the user land should not surface to the global scheduler and the implementation should do its' best to run the task even at the cost of skipping offloading. Modification: `DefaultExecutor.SingleThreadedScheduler#schedule` is guarded against rejections from the user's `offloadExecutor` and triest to fallback and execute the task on its' own thread. Result: User error does not prevent the `SingleThreadedScheduler` from executing future tasks.
chemicL
requested review from
bondolo,
tkountis,
idelpivnitskiy and
Scottmitch
idelpivnitskiy
approved these changes
Nov 4, 2021
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/DefaultExecutor.java
Outdated
Show resolved
Hide resolved
| } | ||
| }, delay, unit); | ||
| // Schedulers are only used to generate a tick and should not execute any user code (unless the | ||
| // offloadExecutor throws). This means they will never run any blocking code and hence it does not matter |
There was a problem hiding this comment.
Yes, this is not ideal that we can run a blocking code on this thread, but should be ok as a workaround for now. In future, we probably need to expend schedule API to also take a consumer of an error.
bondolo
reviewed
Nov 4, 2021
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/DefaultExecutor.java
Outdated
Show resolved
Hide resolved
servicetalk-concurrent-api/src/main/java/io/servicetalk/concurrent/api/DefaultExecutor.java
Show resolved
Hide resolved
…rent/api/DefaultExecutor.java Curtesy of @idelpivnitskiy Co-authored-by: Idel Pivnitskiy <[email protected]>
bondolo
approved these changes
Nov 4, 2021
idelpivnitskiy
added a commit
that referenced
this pull request
Nov 4, 2021
…ailure (#1936) Motivation: When the `Executor` provided by the user fails to accept the task executed by the `SingleThreadedScheduler`, the exception is ignored and the scheduler is no longer usable. The exceptions from the user land should not surface to the global scheduler and the implementation should do its' best to run the task even at the cost of skipping offloading. Modification: `DefaultExecutor.SingleThreadedScheduler#schedule` is guarded against rejections from the user's `offloadExecutor` and triest to fallback and execute the task on its' own thread. Result: User error does not prevent the `SingleThreadedScheduler` from executing future tasks. Co-authored-by: Idel Pivnitskiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When the
Executorprovided by the user fails to accept the taskexecuted by the
SingleThreadedScheduler, the exception is ignored andthe scheduler is no longer usable. The exceptions from the user land
should not surface to the global scheduler and the implementation should
do its' best to run the task even at the cost of skipping offloading.
Modification:
DefaultExecutor.SingleThreadedScheduler#scheduleis guarded againstrejections from the user's
offloadExecutorand triest to fallbackand execute the task on its' own thread.
Result:
User error does not prevent the
SingleThreadedSchedulerfrom executingfuture tasks.