RoundRobinLoadBalancer default Executor with unbounded queue
#1937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The default `Executor` used by `RoundRobinLoadBalancer` for health checking uses a single `Thread` combined with a `SynchronousQueue`. If multiple health checks are executed simultaneously, that can lead to task rejections and health checks failing. The proper implementation can still use a single thread, but should queue scheduled tasks. Modification: Default `RoundRobinLoadBalancerFactory.SharedExecutor` uses a single-threaded, unbounded `ThreadPoolExecutor` to schedule health checks. Result: Health checks can be safely rescheduled using the default executor used by `RoundRobinLoadBalancer`.
chemicL
requested review from
bondolo,
tkountis,
idelpivnitskiy and
Scottmitch
idelpivnitskiy
approved these changes
Nov 4, 2021
bondolo
approved these changes
Nov 4, 2021
|
Verified locally, it fixes the issue. We will add tests in a follow-up |
idelpivnitskiy
pushed a commit
that referenced
this pull request
Nov 4, 2021
Motivation: The default `Executor` used by `RoundRobinLoadBalancer` for health checking uses a single `Thread` combined with a `SynchronousQueue`. If multiple health checks are executed simultaneously, that can lead to task rejections and health checks failing. The proper implementation can still use a single thread, but should queue scheduled tasks. Modification: Default `RoundRobinLoadBalancerFactory.SharedExecutor` uses a single-threaded, unbounded `ThreadPoolExecutor` to schedule health checks. Result: Health checks can be safely rescheduled using the default executor used by `RoundRobinLoadBalancer`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The default
Executorused byRoundRobinLoadBalancerfor healthchecking uses a single
Threadcombined with aSynchronousQueue.If multiple health checks are executed simultaneously, that can lead to
task rejections and health checks failing. The proper implementation can
still use a single thread, but should queue scheduled tasks.
Modification:
Default
RoundRobinLoadBalancerFactory.SharedExecutorusesa single-threaded, unbounded
ThreadPoolExecutorto schedule health checks.Result:
Health checks can be safely rescheduled using the default executor used
by
RoundRobinLoadBalancer.