MessageEncodingException should take an encoding name only
#1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `MessageEncodingException` expects an encoding name only, not a cause. It already has a prepared cause inside a ctor. Modificaitons: - Pass encoding to the `MessageEncodingException` ctor instead of a cause; Result: Users see a correct cause message for `MessageEncodingException`.
idelpivnitskiy
force-pushed
the
ProtoBufSerializationProviderBuilder
branch
from
eadd7c1 to
a621e2a
Compare
tkountis
approved these changes
Nov 8, 2021
bondolo
reviewed
Nov 8, 2021
| @@ -172,7 +172,7 @@ public GrpcSerializationProvider build() { | |||
| @SuppressWarnings("unchecked") | |||
| HttpSerializer<T> httpSerializer = serializersForType.get(codec); | |||
| if (httpSerializer == null) { | |||
| throw new MessageEncodingException("Unknown encoding: " + codec.name()); | |||
There was a problem hiding this comment.
Perhaps instead of the encoding name, which may be non-canonical, the exception could be created with the ContentCodec instance responsible.
There was a problem hiding this comment.
This PR mostly targets 0.41 branch. In the main branch, old serialization is already deprecated. This exception type was missed, but will be deprecated by #1924. Will minimize changes for the code that is going away soon.
idelpivnitskiy
added a commit
that referenced
this pull request
Nov 9, 2021
Motivation: `MessageEncodingException` expects an encoding name only, not a cause. It already has a prepared cause inside a ctor. Modificaitons: - Pass encoding to the `MessageEncodingException` ctor instead of a cause; Result: Users see a correct cause message for `MessageEncodingException`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
MessageEncodingExceptionexpects an encoding name only, not a cause.It already has a prepared cause inside a ctor.
Modifications:
MessageEncodingExceptionctor instead of acause;
Result:
Users see a correct cause message for
MessageEncodingException.