Correctly report TLS handshake when TCP Fast Open is enabled #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When TCP Fast Open socket option is enabled and available by the OS, client sends `ClientHello` message with the initial TCP handshake. We should trigger `onSecurityHandshake()` earlier in this case and give users another callback to see when the TCP handshake completes. Modifications: - Add `ConnectionObserver#onTcpHandshakeComplete()`; - Improve tests to verity new callback; - Adjust `ConnectionObserverInitializer` to trigger `onSecurityHandshake()` earlier when TCP Fast Open is enabled and available; Result: Users can observe TCP and TLS handshake behavior correctly when Fast Open is used.
Scottmitch
reviewed
Dec 1, 2021
| /** | ||
| * Callback when a TCP handshake completes. | ||
| */ | ||
| default void onTcpHandshakeComplete() { |
There was a problem hiding this comment.
I would recommend avoid using tcp at this level bcz we could use the same abstractions for other protocols (udp, ..). Netty uses channelActive terminology and we could use something similar here (e.g. onActive, onConnectionActive, ..)
There was a problem hiding this comment.
Agreed, changed it to onTransportHandshakeComplete(). Debated with myself if this callback really necessary or not. Discussed with @tkountis and he convinced me that it's a lot easier to understand API and events sequencing of the ConnectionObserver if we have it. Thanks for discussion!
Scottmitch
approved these changes
Dec 2, 2021
idelpivnitskiy
added a commit
that referenced
this pull request
Dec 2, 2021
Motivation: When TCP Fast Open socket option is enabled and available by the OS, client sends `ClientHello` message with the initial TCP handshake. We should trigger `onSecurityHandshake()` earlier in this case and give users another callback to see when the TCP handshake completes. Modifications: - Add `ConnectionObserver#onTransportHandshakeComplete()`; - Improve tests to verity new callback; - Adjust `ConnectionObserverInitializer` to trigger `onSecurityHandshake()` earlier when TCP Fast Open is enabled and available; Result: Users can observe TCP and TLS handshake behavior correctly when Fast Open is used.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Dec 3, 2021
Motivation: apple#1969 and apple#1970 introduced two new callbacks for `ConnectionObserver` and added default impl for backward compatibility. We can clean up API in 0.42. Modifications: - Remove default impl for `onTransportHandshakeComplete()` and `streamIdAssigned`; Result: No default callback impls.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Dec 14, 2021
Motivation: apple#1970 removed a public ctor from `ConnectionObserverInitializer`. We should revert it back to make the class backward compatible. Modifications: - Revert `ConnectionObserverInitializer(ConnectionObserver, boolean)`; Result: `ConnectionObserverInitializer` is backward compatible.
bondolo
pushed a commit
that referenced
this pull request
Dec 14, 2021
Motivation: #1970 removed a public ctor from `ConnectionObserverInitializer`. We should revert it back to make the class backward compatible. Modifications: - Revert `ConnectionObserverInitializer(ConnectionObserver, boolean)`; Result: `ConnectionObserverInitializer` is backward compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When TCP Fast Open socket option is enabled and available by the OS,
client sends
ClientHellomessage with the initial TCP handshake. Weshould trigger
onSecurityHandshake()earlier in this case and giveusers another callback to see when the TCP handshake completes.
Modifications:
ConnectionObserver#onTransportHandshakeComplete();ConnectionObserverInitializerto triggeronSecurityHandshake()earlier when TCP Fast Open is enabled andavailable;
Result:
Users can observe TCP and TLS handshake behavior correctly when
Fast Open is used.