Read/WriteObserver: give users visibility into items
#2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Existing `ReadObserver` and `WriteObserver` API sends signals without letting users know what exactly was read or written. Modifications: - Add `ReadObserver#itemRead(Object)`, deprecate `ReadObserver#itemRead()`; - Add `WriteObserver#itemReceived(Object)`, deprecate `WriteObserver#itemReceived()`; - Add `WriteObserver#itemWritten(Object, long)`, deprecate `WriteObserver#itemWritten()`; - Add `WriteObserver#itemFlushed(Object)`; - Update tests and implementations; Result: Users can see what items have been read or written at L4 level.
idelpivnitskiy
requested review from
bondolo,
chemicL,
tkountis and
Scottmitch
idelpivnitskiy
force-pushed
the
items
branch
from
f212705 to
a795faa
Compare
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Dec 11, 2021
Motivation: apple#2013 deprecates some methods on `Read/WriteObserver`. Modifications: - Swap default impl from new to deprecated method; Result: Users can remove usage of the deprecated methods.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Dec 11, 2021
Motivation: apple#2013 deprecates some methods on `Read/WriteObserver`. Modifications: - Swap default impl from new to deprecated method; Result: Users can remove usage of the deprecated methods.
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Dec 11, 2021
Motivation: apple#2013 deprecates some methods on `Read/WriteObserver`. Modifications: - Swap default impl from new to deprecated method; Result: Users can remove usage of the deprecated methods.
idelpivnitskiy
force-pushed
the
items
branch
from
a795faa to
4a2a973
Compare
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Dec 11, 2021
Motivation: Modifications: - Swap default impl from new to deprecated method; Result: Users can remove usage of the deprecated methods.
bondolo
approved these changes
Dec 13, 2021
idelpivnitskiy
added a commit
that referenced
this pull request
Dec 14, 2021
Motivation: Existing `ReadObserver` and `WriteObserver` API sends signals without letting users know what exactly was read or written. Modifications: - Add `ReadObserver#itemRead(Object)`, deprecate `ReadObserver#itemRead()`; - Add `WriteObserver#itemReceived(Object)`, deprecate `WriteObserver#itemReceived()`; - Add `WriteObserver#itemWritten(Object)`, deprecate `WriteObserver#itemWritten()`; - Add `WriteObserver#itemFlushed(Object)`; - Update tests and implementations; Result: Users can see what items have been read or written at L4 level.
idelpivnitskiy
added a commit
that referenced
this pull request
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Existing
ReadObserverandWriteObserverAPI sends signals withoutletting users know what exactly was read or written.
Modifications:
ReadObserver#itemRead(Object), deprecateReadObserver#itemRead();WriteObserver#itemReceived(Object), deprecateWriteObserver#itemReceived();WriteObserver#itemWritten(Object), deprecateWriteObserver#itemWritten();WriteObserver#itemFlushed(Object);Result:
Users can see what items have been read or written at L4 level.