[Backport] Unified retry / auto-retry filter support #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkountis
added
API
Motivation: Use of AutoRetry alongside a RetryingHttpRequesterFilter creates issues with the retrying logic exponentially increasing to the product of the two max-retry settings. The conflict arises when both solutions are configured to retry RetryableExceptions which is the case by default. Modifications: AutoRetry logic is deprecated, to be removed in the future. The logic of the AutoRetry is merged with the RetryingHttpRequesterFilter which now allows retryable flows. Different exceptions can have different retry, as well as support for retries of responses. Results: Unified API (cherry picked from commit 7f0b3b3)
* Minor improvements for uniform retry-filter (cherry picked from commit bbae7d0)
Motivation: New retrying http request filter has bug when the factory is shared across client builders. Modifications: Internalized the state to the filter, where the lazy injection now happens rather than the factory as it was before. Result: Safer implementation (cherry picked from commit cbd3e41)
tkountis
force-pushed
the
retry-backport
branch
from
1905143 to
dd257ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Use of
AutoRetryalongside aRetryingHttpRequesterFiltercreates issues with the retrying logic exponentially increasing to the product of the two max-retry settings. The conflict arises when both solutions are configured to retryRetryableExceptions which is the case by default.Modifications:
AutoRetrylogic is deprecated, to be removed in the future.AutoRetryis merged with theRetryingHttpRequesterFilterwhich now allows retryable flows. Different exceptions can have different retry, as well as support for retries of responses.Results:
Unified API for retries.
Note:
This is a cherry-picked combination of 3 PRs to the
mainbranch, see #1905, #2004, #2018.