Prevent retry logic modifications through the builder #2031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The final retry predicate depends on class variables of the builder in `RetryingHttpRequesterFilter`. User can keep a reference to the builder and modify functions to change the retry behavior in runtime. Modifications: - Capture the context of the builder state in `final` variables to eliminate any runtime behavior change in `RetryingHttpRequesterFilter`; Result: `RetryingHttpRequesterFilter` behavior can not be altered through the builder at runtime.
tkountis
approved these changes
Dec 20, 2021
| @@ -705,6 +705,16 @@ public Builder retryOther( | |||
| * @return A new retrying {@link RetryingHttpRequesterFilter} | |||
| */ | |||
| public RetryingHttpRequesterFilter build() { | |||
| final BiFunction<HttpRequestMetaData, RetryableException, BackOffPolicy> retryRetryableExceptions = | |||
idelpivnitskiy
added a commit
that referenced
this pull request
Dec 21, 2021
Motivation: The final retry predicate depends on class variables of the builder in `RetryingHttpRequesterFilter`. User can keep a reference to the builder and modify functions to change the retry behavior in runtime. Modifications: - Capture the context of the builder state in `final` variables to eliminate any runtime behavior change in `RetryingHttpRequesterFilter`; Result: `RetryingHttpRequesterFilter` behavior can not be altered through the builder at runtime.
bondolo
pushed a commit
that referenced
this pull request
Dec 21, 2021
Motivation: The final retry predicate depends on class variables of the builder in `RetryingHttpRequesterFilter`. User can keep a reference to the builder and modify functions to change the retry behavior in runtime. Modifications: - Capture the context of the builder state in `final` variables to eliminate any runtime behavior change in `RetryingHttpRequesterFilter`; Result: `RetryingHttpRequesterFilter` behavior can not be altered through the builder at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The final retry predicate depends on class variables of the builder in
RetryingHttpRequesterFilter. User can keep a reference to the builderand modify functions to change the retry behavior in runtime.
Modifications:
finalvariables toeliminate any runtime behavior change in
RetryingHttpRequesterFilter;Result:
RetryingHttpRequesterFilterbehavior can not be altered through thebuilder at runtime.