Fix infinite retries under particular conditions #2041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When the new retrying http filter is applied under some particular conditions, the retry logic yields infinite attempts. Modifications: - When the filter is appended conditionally, capture the instance to lazy inject LB/SD state. - Change the default max-total-retries to guard better LB/SD error flow. - Additional input validation for durations. Result: Safe retry behaviour.
tkountis
force-pushed
the
fix-retry-issues1
branch
from
8848c2a to
1d91d7f
Compare
idelpivnitskiy
approved these changes
Jan 6, 2022
...ttp-netty/src/main/java/io/servicetalk/http/netty/DefaultSingleAddressHttpClientBuilder.java
Outdated
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java
Show resolved
Hide resolved
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java
Outdated
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Jan 8, 2022
tkountis
added a commit
to tkountis/servicetalk
that referenced
this pull request
Jan 8, 2022
Motivation: When the new retrying http filter is applied under some particular conditions, the retry logic yields infinite attempts. Modifications: - When the filter is appended conditionally, capture the instance to lazy inject LB/SD state. - Change the default max-total-retries to guard better LB/SD error flow. - Additional input validation for durations. Result: Safe retry behavior. (cherry picked from commit e04a01a)
tkountis
added a commit
that referenced
this pull request
Jan 8, 2022
Motivation: When the new retrying http filter is applied under some particular conditions, the retry logic yields infinite attempts. Modifications: - When the filter is appended conditionally, capture the instance to lazy inject LB/SD state. - Change the default max-total-retries to guard better LB/SD error flow. - Additional input validation for durations. Result: Safe retry behavior. (cherry picked from commit e04a01a)
tkountis
added a commit
to tkountis/servicetalk
that referenced
this pull request
Jan 11, 2022
Motivation: When the new retrying http filter is applied under some particular conditions, the retry logic yields infinite attempts. Modifications: - When the filter is appended conditionally, capture the instance to lazy inject LB/SD state. - Change the default max-total-retries to guard better LB/SD error flow. - Additional input validation for durations. Result: Safe retry behavior.
tkountis
added a commit
to tkountis/servicetalk
that referenced
this pull request
Jan 11, 2022
Motivation: When the new retrying http filter is applied under some particular conditions, the retry logic yields infinite attempts. Modifications: - When the filter is appended conditionally, capture the instance to lazy inject LB/SD state. - Change the default max-total-retries to guard better LB/SD error flow. - Additional input validation for durations. Result: Safe retry behavior.
tkountis
added a commit
to tkountis/servicetalk
that referenced
this pull request
Jan 11, 2022
Motivation: When the new retrying http filter is applied under some particular conditions, the retry logic yields infinite attempts. Modifications: - When the filter is appended conditionally, capture the instance to lazy inject LB/SD state. - Change the default max-total-retries to guard better LB/SD error flow. - Additional input validation for durations. Result: Safe retry behavior.
tkountis
added a commit
that referenced
this pull request
Jan 11, 2022
Motivation: When the new retrying http filter is applied under some particular conditions, the retry logic yields infinite attempts. Modifications: - When the filter is appended conditionally, capture the instance to lazy inject LB/SD state. - Change the default max-total-retries to guard better LB/SD error flow. - Additional input validation for durations. Result: Safe retry behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When the new retrying http filter is applied under some particular conditions, the retry logic yields infinite attempts.
Modifications:
Result:
Safe retry behaviour.