[Backport] HTTP Expect: 100-continue (#2037)
#2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Add support for `Expect: 100-continue` header to allow users deffer sending request payload body until server signals that it's ready to receive it. Modification: - Enhance `HttpObjectEncoder`, `HttpObjectDecoder`, `AbstractH2DuplexHandler`, their subclasses, and `NettyHttpServer` to support new feature; - `DefaultNettyConnection`: add `ContinueUserEvent` and `CancelWriteUserEvent`; - `WriteStreamSubscriber`: add `continueWriting()` and `terminateSource()` to support continuation; - Fix `WriteStreamSubscriber#channelWritable()` to make `initialRequestN` if subscription was assigned while a channel was not writable; - `RequestResponseCloseHandler` and `NonPipelinedCloseHandler`: fire `OutboundDataEndEvent` only when it ends outbound data but not when `CancelWriteUserEvent`; - `HttpProtocolVersion`: implement `Comparable` interface to allow easier version number comparison; - `RetryingHttpRequesterFilter`: add `retryExpectationFailed(boolean)` feature and public `ExpectationFailedException`; - Test new behavior; - Add docs section about `Expect: 100-continue` for http-api module; Result: HTTP supports `Expect: 100-continue` feature on client and server sides.
idelpivnitskiy
force-pushed
the
0.41-expect-continue
branch
from
fc9eda5 to
8805da6
Compare
idelpivnitskiy
added a commit
that referenced
this pull request
Feb 9, 2022
Motivation: #2079 added a new argument for 2 public methods of `io.servicetalk.transport.netty.internal.DefaultNettyConnection`. While this is an internal class, we should be extra cautious with any incompatible changes in 0.41 branch. Modifications: - Add 2 more overloads for pre-existing methods and mark them as `@Deprecated`; Result: `servicetalk-transport-netty-internal` module is backward compatible with 0.41.13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Add support for
Expect: 100-continueheader to allow users deffersending request payload body until server signals that it's ready to
receive it.
Modification:
HttpObjectEncoder,HttpObjectDecoder,AbstractH2DuplexHandler, their subclasses, andNettyHttpServertosupport new feature;
DefaultNettyConnection: addContinueUserEventandCancelWriteUserEvent;WriteStreamSubscriber: addcontinueWriting()andterminateSource()to support continuation;WriteStreamSubscriber#channelWritable()to makeinitialRequestNif subscription was assigned while a channel was notwritable;
RequestResponseCloseHandlerandNonPipelinedCloseHandler: fireOutboundDataEndEventonly when it ends outbound data but not whenCancelWriteUserEvent;HttpProtocolVersion: implementComparableinterface to alloweasier version number comparison;
RetryingHttpRequesterFilter: addretryExpectationFailed(boolean)feature and public
ExpectationFailedException;Expect: 100-continuefor http-api module;Result:
HTTP supports
Expect: 100-continuefeature on client and server sides.