NettyIoThread should implement ContextMapHolder
#2083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: apple#1910 could not change `io.servicetalk.transport.api.IoThreadFactory.IoThread` to extend `ContextMapHolder` to keep it backward compatible. But the internal `NettyIoThread` must implement `ContextMapHolder`. Otherwise, all netty threads go through slow path of managing `AsyncContext`. Modifications: - `NettyIoThread` implements `ContextMapHolder`; Result: All instances of `NettyIoThread`s go through the fast path of operating with `ContextMap`.
tkountis
approved these changes
Feb 9, 2022
bondolo
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
#1910 could not change
io.servicetalk.transport.api.IoThreadFactory.IoThreadto extendContextMapHolderto keep it backward compatible. But the internalNettyIoThreadmust implementContextMapHolder. Otherwise, allnetty threads go through slow path of managing
AsyncContext.Modifications:
NettyIoThreadimplementsContextMapHolder;Result:
All instances of
NettyIoThreads go through the fast path of operatingwith
ContextMap.