ConnectionFactory-level filters can not migrate to new API of #1956 #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: In apple#1956 `StreamingHttpRequester` defines a new method `request(StreamingHttpRequest)`. `AbstractStreamingHttpConnection` only implements the deprecated method that also takes an `HttpExecutionStrategy`. Users who apply a filter through `ConnectionFactory` see `UnsupportedOperationException`. Also, if they have 2+ filters applied through `ConnectionFactory`, they can not mix deprecated and new API. Modifications: - Implement `AbstractStreamingHttpConnection#request(StreamingHttpRequest)`; - Enhance `NewToDeprecatedFilter` to be `ConnectionFactoryFilter` too; - Apply `NewToDeprecatedFilter` when users invoke `appendConnectionFactoryFilter`; - Test `appendConnectionFactoryFilter` in `MixedFiltersTest`; Result: Users who apply request/response filters through `ConnectionFactory` can migrate from deprecated to new `request(StreamingHttpRequest)` API.
bondolo
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In #1956
StreamingHttpRequesterdefines a new methodrequest(StreamingHttpRequest).AbstractStreamingHttpConnectiononlyimplements the deprecated method that also takes an
HttpExecutionStrategy. Users who apply a filter throughConnectionFactoryseeUnsupportedOperationException. Also, if theyhave 2+ filters applied through
ConnectionFactory, they can not mixdeprecated and new API.
Modifications:
AbstractStreamingHttpConnection#request(StreamingHttpRequest);NewToDeprecatedFilterto beConnectionFactoryFiltertoo;NewToDeprecatedFilterwhen users invokeappendConnectionFactoryFilter;appendConnectionFactoryFilterinMixedFiltersTest;Result:
Users who apply request/response filters through
ConnectionFactorycan migrate from deprecated to new
request(StreamingHttpRequest)API.