CompositeCloseable: prepend doesn't respect ordering #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: `DefaultCompositeCloseable` does not respect ordering if `prepend` operation is invoked after `append`. Modifications: - Change `Operand.closables` to `ArrayDeque`; - Use `addFirst` for `prepend` operation; - Test ordiring for "prepend after append" and "prepend after merge"; Result: Correct ordering of invoking `AsyncCloseable`s if `prepend` is used after `append`.
bondolo
approved these changes
Feb 23, 2022
| @@ -203,8 +202,8 @@ private Completable buildCompletable(Function<AsyncCloseable, Completable> close | |||
| } | |||
|
|
|||
| private static final class Operand { | |||
| private final List<AsyncCloseable> closables = new ArrayList<>(4); | |||
| private final boolean isMerge; | |||
| final Deque<AsyncCloseable> closables = new ArrayDeque<>(2); | |||
There was a problem hiding this comment.
The default size of the collection changes. There is probably no reason not to still use 4 as that still typically fits within the alignment size of a heap allocation of a reference array. ie. The first resize to 4 will probably just reallocate to another array with less wasted space.
idelpivnitskiy
added a commit
that referenced
this pull request
Feb 23, 2022
Motivation: `DefaultCompositeCloseable` does not respect ordering if `prepend` operation is invoked after `append`. Modifications: - Change `Operand.closables` to `ArrayDeque`; - Use `addFirst` for `prepend` operation; - Test ordiring for "prepend after append" and "prepend after merge"; Result: Correct ordering of invoking `AsyncCloseable`s if `prepend` is used after `append`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
DefaultCompositeCloseabledoes not respect ordering ifprependoperation is invoked after
append. It causes issues when the orderingmatters for closeable resources that depend upon each other.
Modifications:
Operand.closablestoArrayDeque;addFirstforprependoperation;Result:
Correct ordering of invoking
AsyncCloseables ifprependis usedafter
append.