Increase log level when global resources are closed #2105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Closing global resources (`IoExecutor` and `Executor`) is unexpected. Users should have visibility when it happens. Modifications: - Change log level from `debug` to `info`; - Add stack-trace to see where subscribe comes from; Result: Users can notice if they unexpectedly closed any of the global resources.
tkountis
approved these changes
Feb 23, 2022
bondolo
approved these changes
Feb 23, 2022
...y-internal/src/main/java/io/servicetalk/transport/netty/internal/GlobalExecutionContext.java
Outdated
Show resolved
Hide resolved
|
All tests passed for the previous run, I will merge without waiting for CI, the last commit is trivial |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Closing global resources (
IoExecutorandExecutor) is unexpected.Users should have visibility when it happens.
Modifications:
debugtoinfo;Result:
Users can notice if they unexpectedly closed any of the global
resources.