Publisher.multicast lack of demand on cancel #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Publisher.multicast fails to request more from upstream if the Subscription with the minimum demand cancels. This may result in a live lock because the remaining Subscribers have requested data but that request hasn't been communicated upstream. Modifications: - Publisher.multicast checks when a Subscription is cancelled if it is has the minimum demand more must be requested from upstream. Result: No more live lock if the minimum demand Subscription cancels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Publisher.multicast fails to request more from upstream
if the Subscription with the minimum demand cancels.
This may result in a live lock because the remaining
Subscribers have requested data but that request hasn't
been communicated upstream.
Modifications:
cancelled if it is has the minimum demand more
must be requested from upstream.
Result:
No more live lock if the minimum demand Subscription cancels.