Add netty-tcnative-boringssl-static runtime dependency #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: netty-tcnative-boringssl-static accelerates TLS and is enabled if included on the classpath. ServiceTalk include's Netty's bom which now also includes the compatible tcnative version, so we can include this dependency to simplify version alignment. Modifications: - Add netty-tcnative-boringssl-static runtimeOnly dependency for macOS/linux x86-64/aarch-64 Result: Accelerated TLS without coordinating versions manually.
Scottmitch
commented
Mar 1, 2022
chemicL
approved these changes
Mar 1, 2022
idelpivnitskiy
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
netty-tcnative-boringssl-static accelerates TLS and is enabled
if included on the classpath. ServiceTalk include's Netty's bom
which now also includes the compatible tcnative version, so we
can include this dependency to simplify version alignment.
Modifications:
macOS/linux x86-64/aarch-64
Result:
Accelerated TLS without coordinating versions manually.