Deprecate offloadNever()
#2133
Merged
Deprecate offloadNever()
#2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Currently there is a special `HttpExecutionStrategy` that has unusual behavior when merged with other `HttpExecutionStrategy`s, specifically the `merge()` always returns the `offloadNever()` strategy. To reduce complexity and make the behavior of merge more consistent the special merge behavior will be eliminated. Modifications: Replace uses of `offloadNever()`, where possible with `offloadNone()` and eliminate dependence of ServiceTalk implementation on the current special merge behavior. Result: Simplified implementation with more consistent behavior.
bondolo
changed the title
offloadNever()
idelpivnitskiy
approved these changes
Mar 11, 2022
servicetalk-grpc-api/src/main/java/io/servicetalk/grpc/api/GrpcExecutionStrategies.java
Outdated
Show resolved
Hide resolved
servicetalk-http-api/src/main/java/io/servicetalk/http/api/HttpExecutionStrategies.java
Show resolved
Hide resolved
servicetalk-http-api/src/main/java/io/servicetalk/http/api/SpecialHttpExecutionStrategy.java
Show resolved
Hide resolved
servicetalk-grpc-api/src/main/java/io/servicetalk/grpc/api/GrpcExecutionStrategies.java
Show resolved
Hide resolved
servicetalk-http-api/src/main/java/io/servicetalk/http/api/HttpExecutionStrategies.java
Show resolved
Hide resolved
servicetalk-http-api/src/main/java/io/servicetalk/http/api/SpecialHttpExecutionStrategy.java
Outdated
Show resolved
Hide resolved
...http-netty/src/main/java/io/servicetalk/http/netty/ClientStrategyInfluencerChainBuilder.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently there is a special
HttpExecutionStrategy,offloadNever(), thathas unusual behavior when merged with other
HttpExecutionStrategys,specifically the
merge()always returns theoffloadNever()strategy. Toreduce complexity and make the behavior of merge more consistent the
special merge behavior will be eliminated and this special strategy will be
deprecated for eventual removal.
Modifications:
Replace uses of
offloadNever(), where possible withoffloadNone()and eliminate dependence of ServiceTalk implementation on the current
special merge behavior. Deprecate the special
offloadNever()strategy.Result:
Simplified implementation with more consistent behavior.