Conditionally use ioExecutor timer for retry #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The `RetryingHttpRequesterFilter` uses the context executor timer for scheduling retry attempt. If offloading is disabled it should use the context ioExecutor timer instead. Modifications: Use the appropriate timer based upon context execution strategy. Result: Retry timer will not use the context executor for scheduled retries if offloading is disabled.
tkountis
reviewed
Mar 9, 2022
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java
Show resolved
Hide resolved
idelpivnitskiy
approved these changes
Mar 11, 2022
servicetalk-http-netty/src/main/java/io/servicetalk/http/netty/RetryingHttpRequesterFilter.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The
RetryingHttpRequesterFilteruses the context executor timer forscheduling retry attempt. If offloading is disabled it should use the
context ioExecutor timer instead.
Modifications:
Use the appropriate timer based upon context execution strategy.
Result:
Retry timer will not use the context executor for scheduled retries if
offloading is disabled.