grpc-protoc addService -> addBlockingService #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The generated code to build a service has two methods with the same name: * `addService(X)` * `addService(BlockingX)` The method overloading approach requires that folks cast their services if they are implemented as lambdas. We can avoid this ambiguity by qualifying the method name to: * `addBlockingService(BlockingX)`
tkountis
approved these changes
Mar 10, 2022
| serviceBuilderSpecBuilder.addMethod(methodBuilder(addService) | ||
| .addModifiers(PUBLIC) | ||
| .addAnnotation(Deprecated.class) | ||
| .addJavadoc(JAVADOC_DEPRECATED + "Use {@link #$L($T)}." + lineSeparator(), addBlockingService, |
There was a problem hiding this comment.
We have to add a full javadoc. Otherwise, there are other warnings, like missing @param that break the build with Xwerror flag.
There was a problem hiding this comment.
will submit a followup
There was a problem hiding this comment.
this is what I meant about javadoc generation not reliably detecting issues. hopefully #2140 will help but there are protobuf issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The generated code to build a service has two methods
with the same name:
addService(X)addService(BlockingX)The method overloading approach requires that folks cast their
services if they are implemented as lambdas. We can avoid
this ambiguity by qualifying the method name to:
addBlockingService(BlockingX)