Let ConnectionFactory see difference between proxied and direct connections
#2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idelpivnitskiy
changed the title
ConnectionFactory see difference between proxied and direct connectionsConnectionFactory to see difference between proxied and direct connections
idelpivnitskiy
changed the title
ConnectionFactory to see difference between proxied and direct connectionsConnectionFactory see difference between proxied and direct connections
bondolo
approved these changes
Apr 8, 2022
servicetalk-client-api/src/main/java/io/servicetalk/client/api/ConnectionFactory.java
Outdated
Show resolved
Hide resolved
servicetalk-client-api/src/main/java/io/servicetalk/client/api/LoadBalancer.java
Outdated
Show resolved
Hide resolved
bondolo
reviewed
Apr 8, 2022
| Single<C> newConnection(ResolvedAddress address, @Nullable TransportObserver observer); | ||
| default Single<C> newConnection(ResolvedAddress address, @Nullable ContextMap context, | ||
| @Nullable TransportObserver observer) { // FIXME: 0.43 - remove default impl | ||
| return Single.defer(() -> { |
There was a problem hiding this comment.
What will the implementation be when Connection factory implementations override this method? Are they to implement the defer and the addition of the key to the context?
There was a problem hiding this comment.
No, the defer here is only necessary to "glue" the old overload with DeprecatedToNewConnectionFactoryFilter. If users implement this method, it's expected that they will invoke the same method in delegate chain, skipping the AsyncContext dance and directly propagating the context to the next filter.
chemicL
reviewed
Apr 13, 2022
| /** | ||
| * Default implementation of {@link ContextMap}. | ||
| * <p> | ||
| * Note: it's not concurrent! |
There was a problem hiding this comment.
I suppose better wording would be "it's not thread-safe".
Motivation: Connection initialization sequence is different for a secure HTTP proxy tunnels. It's necessary for the `ConnectionFactory` and `TransportObserver` to know if the `newConnection` is invoked for a regular connection or a proxy tunnel in order to correctly count timing of events. Modifications: - Introduce new `HttpContextKeys#HTTP_TARGET_ADDRESS_BEHIND_PROXY` key; - Enhance `ProxyConnectConnectionFactoryFilter` and `AbsoluteAddressHttpRequesterFilter` to fill the value for `HTTP_TARGET_ADDRESS_BEHIND_PROXY`; - Enhance proxy tests to verify that the key value always present; Result: Users can distinguish attempts to open direct connections and connections through a proxy.
idelpivnitskiy
force-pushed
the
HTTP_TARGET_ADDRESS_BEHIND_PROXY
branch
from
7104d9a to
cae941b
Compare
idelpivnitskiy
added a commit
to idelpivnitskiy/servicetalk
that referenced
this pull request
Oct 2, 2023
Motivation: Prior to `ConnectionObserver.ProxyConnectObserver` added in apple#2711, the sequence of `ConnectionObserver` events was different between regular connections and connection to the proxy tunnels. `HttpContextKeys.HTTP_TARGET_ADDRESS_BEHIND_PROXY` (apple#2169) was useful to distinguish when the correct callback inside `ConnectionObserver` before reporting that a new connection is ready to take traffic. After adding `ProxyConnectObserver`, there is no need in this custom key. Modifications: - Deprecate `HttpContextKeys.HTTP_TARGET_ADDRESS_BEHIND_PROXY` and describe what is an appropriate replacement for users; Result: We will be able to remove `HttpContextKeys.HTTP_TARGET_ADDRESS_BEHIND_PROXY` in the future releases.
idelpivnitskiy
added a commit
that referenced
this pull request
Oct 3, 2023
Motivation: Prior to `ConnectionObserver.ProxyConnectObserver` added in #2711, the sequence of `ConnectionObserver` events was different between regular connections and connection to the proxy tunnels. `HttpContextKeys.HTTP_TARGET_ADDRESS_BEHIND_PROXY` (#2169) was useful to distinguish when the correct callback inside `ConnectionObserver` before reporting that a new connection is ready to take traffic. After adding `ProxyConnectObserver`, there is no need in this custom key. Modifications: - Deprecate `HttpContextKeys.HTTP_TARGET_ADDRESS_BEHIND_PROXY` and describe what is an appropriate replacement for users; Result: We will be able to remove `HttpContextKeys.HTTP_TARGET_ADDRESS_BEHIND_PROXY` in the future releases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The connection initialization sequence is different for secure HTTP proxy
tunnels. It's necessary for the
ConnectionFactoryandTransportObserverto know if thenewConnection(...)is being invoked fora regular connection or a proxy tunnel in order to correctly count timing
of events.
Modifications:
HttpContextKeys#HTTP_TARGET_ADDRESS_BEHIND_PROXYkey;ProxyConnectConnectionFactoryFilterandAbsoluteAddressHttpRequesterFilterto fill in the value forHTTP_TARGET_ADDRESS_BEHIND_PROXY;Result:
Users can distinguish attempts to open direct connections and
connections through a proxy.
Depends on #2168, review starting from the 2nd commit.