Let users move GrpcLifecycleObserver in the filter chain
#2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: gRPC users can not use `HttpLifecycleObserverServiceFilter` to install `GrpcLifecycleObserver` because `onGrpcStatus` won't be invoked. Sometimes, it's necessary to see the state of other filters from inside the observer. Modifications: - Make `HttpLifecycleObserverServiceFilter` extensible as a class, but keep all its methods `final`; - Add `GrpcLifecycleObserverServiceFilter`; Result: Users can install `GrpcLifecycleObserver` anywhere in a filter chain.
Scottmitch
approved these changes
Apr 1, 2022
| @@ -161,6 +161,12 @@ public final HttpExecutionStrategy requiredOffloads() { | |||
| return HttpExecutionStrategies.offloadNone(); | |||
| } | |||
|
|
|||
| @Override | |||
| public final HttpExecutionStrategy influenceStrategy(final HttpExecutionStrategy strategy) { | |||
There was a problem hiding this comment.
is it necessary to implement both methods? I thought @bondolo set this up so that if requiredOffloads is implemented we should take the strategy from there?
There was a problem hiding this comment.
The goal was to make all existing methods final even if they are deprecated. It won't be invoked at runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
gRPC users can not use
HttpLifecycleObserverServiceFilterto installGrpcLifecycleObserverbecauseonGrpcStatuswon't be invoked.Sometimes, it's necessary to see the state of other filters from inside
the observer.
Modifications:
HttpLifecycleObserverServiceFilterextensible as a class, butkeep all its methods
final;GrpcLifecycleObserverServiceFilter;Result:
Users can install
GrpcLifecycleObserveranywhere in a filter chain.