Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoundRobinLoadBalancer: increase visibility into health-checking #2182

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

idelpivnitskiy
Copy link
Member

Motivation:

Currently, health-checking events are logged at DEBUG level and the
failure cause is not propagated. Users have to change the logging level
and reproduce in order to understand the root cause.

Modifications:

  • Log each failed attempt to create a connection at INFO level for
    visibility;
  • Log at WARN level when the health-checking is triggered;
  • Retain the last cause that triggered health-checking inside
    HealthCheck state to use it for toString();

Result:

Users see when a connectivity issue occurs, cause is logged and
propagated for subsequent selection attempts if there are no other
ACTIVE hosts.

Motivation:

Currently, health-checking events are logged at `DEBUG` level and the
failure cause is not propagated. Users have to change the logging level
and reproduce in order to understand the root cause.

Modifications:

- Log each failed attempt to create a connection at `INFO` level for
visibility;
- Log at `WARN` level when the health-checking is triggered;
- Retain the last cause that triggered health-checking inside
`HealthCheck` state to use it for `toString()`;

Result:

Users see when a connectivity issue occurs, cause is logged and
propagated for subsequent selection attempts if there are no other
`ACTIVE` hosts.
@idelpivnitskiy idelpivnitskiy self-assigned this Apr 8, 2022
@idelpivnitskiy idelpivnitskiy merged commit fce6b3e into apple:main Apr 8, 2022
@idelpivnitskiy idelpivnitskiy deleted the rrlb-logging branch April 8, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants