RoundRobinLoadBalancer
: increase visibility into health-checking
#2182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, health-checking events are logged at
DEBUG
level and thefailure cause is not propagated. Users have to change the logging level
and reproduce in order to understand the root cause.
Modifications:
INFO
level forvisibility;
WARN
level when the health-checking is triggered;HealthCheck
state to use it fortoString()
;Result:
Users see when a connectivity issue occurs, cause is logged and
propagated for subsequent selection attempts if there are no other
ACTIVE
hosts.