Fix regression of client offloadNone() strategy
#2192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bondolo - test failure occurred, is it related to these changes? |
|
The test's assumptions appear to be incorrect. I will take a look |
Motivation: The changes in apple#2108 introduced a regression in the handling of computation of the effective strategy of a client when a strategy `offloadNone()` (or the deprecated `offloadNever()`) was used with the `HttpClientBuilder`. Rather than preventing all offloading, the computed offloading was used. Modifications: If the strategy specified on the `HttpClientBuilder` does not specify any offloads then no offloading will be used. Result: The offloading behavior matches the requested behavior specified on the `HttpClientBuilder`.
bondolo
force-pushed
the
offloadNone-regression
branch
from
f7cbfe2 to
5b59b43
Compare
|
The fix to this regression was independently fixed in #2166. This PR extracts the only the necessary fix along with required test changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The changes in #2108 introduced a regression in the handling of
computation of the effective strategy of a client when a
strategy
offloadNone()(or the deprecatedoffloadNever()) was usedwith the
HttpClientBuilder. Rather than preventing all offloading,the computed offloading was used.
Modifications:
If the strategy specified on the
HttpClientBuilderdoes not specifyany offloads then no offloading will be used.
Result:
The offloading behavior matches the requested behavior specified on
the
HttpClientBuilder.