Clarify AsyncContext concurrency docs #2199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifications: async-context.adoc provides some examples to describe control flow and potential concurrent modification scenarios. The example with the operator flow doesn't provide enough explanation to understand the expected control flow. Modifications: - Add more comments to the example and code which shows expected values on key modified "later" in the operator chain.
bondolo
approved these changes
Apr 25, 2022
| // AsyncContext will be copied/isolated when this async source is subscribed to. Changes to the AsyncContext map from | ||
| // async operators on inner operator chain will therefore not be visible in the outer operator chain. | ||
| // AsyncContext will be copied when Single.subscribe(..) is called. Changes to the AsyncContext map from operators on | ||
| // the inner Single operator chain will therefore not be visible in the outer Publisher operator chain. |
There was a problem hiding this comment.
You may wish to add as a comment where the shareContextOnSubscribe() would go if they wanted a shared context.
There was a problem hiding this comment.
Lets consider this as a followup PR. I don't want to overload concepts in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications:
async-context.adoc provides some examples to describe
control flow and potential concurrent modification scenarios.
The example with the operator flow doesn't provide enough
explanation to understand the expected control flow.
Modifications:
shows expected values on key modified "later" in the
operator chain.