Avoid self-suppression for exceptions #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation:
In case a processing function re-throws the original exception, we risk
to face `IllegalArgumentException("Self-suppression not permitted)` when
operator adds a re-thrown exception as suppressed.
Modifications:
- Add utility that verifies the suppressed exception is not the same as
the original one;
Result:
No `IllegalArgumentException("Self-suppression not permitted)`.
bondolo
approved these changes
May 11, 2022
...-http-netty/src/main/java/io/servicetalk/http/netty/AbstractLifecycleObserverHttpFilter.java
Outdated
Show resolved
Hide resolved
...talk-transport-api/src/main/java/io/servicetalk/transport/api/CatchAllTransportObserver.java
Outdated
Show resolved
Hide resolved
bondolo
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In case a processing function re-throws the original exception, we risk
to face
IllegalArgumentException("Self-suppression not permitted)whenoperator adds a re-thrown exception as suppressed.
Modifications:
the original one;
Result:
No
IllegalArgumentException("Self-suppression not permitted).